Skip to content

Update custom file name patterns when copy files and remove problematic parameters in export #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update custom file name patterns when copy files and remove problematic parameters in export #520

wants to merge 2 commits into from
+7 −2

Conversation

@Edwardf0t1
Copy link
Contributor

@Edwardf0t1 Edwardf0t1 commented Nov 6, 2025 •
edited
Loading

What does this PR do?

Type of change: Bugfix

Overview:

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

@Edwardf0t1 Edwardf0t1 requested a review from a team as a code owner November 6, 2025 19:08
@Edwardf0t1 Edwardf0t1 requested a review from realAsma November 6, 2025 19:08
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.52%. Comparing base (ae915ea) to head (7d91e62).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   73.52%   73.52%           
=======================================
  Files         181      181           
  Lines       18207    18207           
=======================================
  Hits        13387    13387           
  Misses       4820     4820

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Edwardf0t1 Edwardf0t1 requested a review from a team as a code owner November 6, 2025 20:06
@Edwardf0t1 Edwardf0t1 requested a review from cjluo-nv November 6, 2025 20:06
@Edwardf0t1 Edwardf0t1 changed the title Update custom file name patterns when copy files in export Update custom file name patterns when copy files and remove problematic parameters in export Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realAsma realAsma Awaiting requested review from realAsma realAsma is a code owner automatically assigned from NVIDIA/modelopt-examples-llm_ptq-codeowners

@cjluo-nv cjluo-nv Awaiting requested review from cjluo-nv cjluo-nv is a code owner automatically assigned from NVIDIA/modelopt-torch-export-codeowners

@kevalmorabia97 kevalmorabia97 Awaiting requested review from kevalmorabia97

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Edwardf0t1